Update the pre-commit hooks #1639
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (88.46%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 232 232
Lines 53081 53087 +6
Branches 9403 9403
=======================================
+ Hits 43342 43348 +6
Misses 7286 7286
Partials 2453 2453
🚀 New features to boost your workflow:
|
| for item in sorted(os.listdir(cache.dirname)) | ||
| if item.startswith("tmp") | ||
| ] | ||
| items = list(Path(cache.dirname).glob("tmp*")) |
There was a problem hiding this comment.
I guess it doesn't matter though
There was a problem hiding this comment.
It is not but yes it doesn't matter here
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pre-commit hooks configuration to use newer versions of the tools and improves code quality by applying automated fixes from the updated ruff linter. The changes include updating from pre-commit-hooks v5.0.0 to v6.0.0, ruff from v0.7.3 to v0.14.0, and making the hook ID more specific (ruff to ruff-check).
- Updated pre-commit hooks to newer versions and applied resulting code quality improvements
- Fixed style issues identified by the newer ruff version across numerous test and source files
- Improved code consistency and readability through automated formatting and linting fixes
Reviewed Changes
Copilot reviewed 133 out of 135 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Updated hook versions and configuration |
| tests/**.py | Applied ruff fixes including unused variable prefixing, regex escaping, and formatting improvements |
| pytensor/**.py | Applied similar code quality improvements to source files |
Comments suppressed due to low confidence (8)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thank you, that's a personal touch :) |
|
Thanks for the review @ricardoV94 , I am merging it because it's the kind of PR that will otherwise quickly need rebasing |
2 participants
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1639.org.readthedocs.build/en/1639/